Conversation
When the PlatformConfig MO is deleted, the agent disconnects the existing peers, and adds the configured ones. When disconnecting the existing peers, it makes a call to uv_close on the libuv handle for the TCP socket. This call is made in a different context than the libuv context that's processing events. This can lead to a race condition, where the libuv handle for that socket is marked as closing, but the libuv thread invokes the pending callbacks for this handle, resulting in the following assert: uv__stream_io: Assertion `!(stream->flags & UV_HANDLE_CLOSING)' failed. To avoid this, the call to uv_close needs to be deferred to the libuv processing context. This patch adds a queue to make deferred close calls, which are handled in the libuv threads async callback.
mchalla
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the PlatformConfig MO is deleted, the agent disconnects the existing peers, and adds the configured ones. When disconnecting the existing peers, it makes a call to uv_close on the libuv handle for the TCP socket. This call is made in a different context than the libuv context that's processing events. This can lead to a race condition, where the libuv handle for that socket is marked as closing, but the libuv thread invokes the pending callbacks for this handle, resulting in the following assert:
uv__stream_io: Assertion `!(stream->flags & UV_HANDLE_CLOSING)' failed.
To avoid this, the call to uv_close needs to be deferred to the libuv processing context. This patch adds a queue to make deferred close calls, which are handled in the libuv threads async callback.